Add the types for id_token and token_type for openid scope#32
Open
mouhannad-sh wants to merge 1 commit intolinkedin-developers:masterfrom
Open
Add the types for id_token and token_type for openid scope#32mouhannad-sh wants to merge 1 commit intolinkedin-developers:masterfrom
mouhannad-sh wants to merge 1 commit intolinkedin-developers:masterfrom
Conversation
2 tasks
ZLeventer
reviewed
Apr 24, 2026
ZLeventer
left a comment
ZLeventer
left a comment
There was a problem hiding this comment.
This is the right fix — id_token and token_type are both missing from the response type. I submitted #41 addressing the same gap.
One note: token_type should probably be required (not optional) since it's always returned per RFC 6749 §5.1, while id_token should be optional since it's only present when openid scope is requested. Worth checking if this PR makes that distinction.
Also filed #43 to track this as an issue independently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the MS documentation
when we perform a successful 3 legged OAuth with
openidandprofilescopes, the api will return theid_tokenandtoken_typeproperties.I noticed that this was missing from the library, hence the PR
Thanks